Welcome! Log In Create A New Profile

Advanced

[PATCH] Core: use uppercase hexadecimal digits for percent-encoding

Piotr Sikora
June 27, 2014 02:42AM
# HG changeset patch
# User Piotr Sikora <piotr@cloudflare.com>
# Date 1403851163 25200
# Thu Jun 26 23:39:23 2014 -0700
# Node ID 177382006b7d7a421688831d5793b2e417074b48
# Parent 42114bf12da0cf3d428d0e695139f5366cbd0513
Core: use uppercase hexadecimal digits for percent-encoding.

RFC3986 says that, for consistency, URI producers and normalizers
should use uppercase hexadecimal digits for all percent-encodings.

This is also what modern web browsers and other tools use.

Using lowercase hexadecimal digits makes it harder to interact with
those tools in case when use of the percent-encoded URI is required,
for example when $request_uri is part of the cache key.

Signed-off-by: Piotr Sikora <piotr@cloudflare.com>

diff -r 42114bf12da0 -r 177382006b7d src/core/ngx_string.c
--- a/src/core/ngx_string.c Mon Jun 16 19:43:25 2014 +0400
+++ b/src/core/ngx_string.c Thu Jun 26 23:39:23 2014 -0700
@@ -1407,7 +1407,7 @@ ngx_escape_uri(u_char *dst, u_char *src,
{
ngx_uint_t n;
uint32_t *escape;
- static u_char hex[] = "0123456789abcdef";
+ static u_char hex[] = "0123456789ABCDEF";

/* " ", "#", "%", "?", %00-%1F, %7F-%FF */


_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Core: use uppercase hexadecimal digits for percent-encoding

Piotr Sikora 753 June 27, 2014 02:42AM

Re: [PATCH] Core: use uppercase hexadecimal digits for percent-encoding

Maxim Dounin 297 June 27, 2014 01:58PM

Re: [PATCH] Core: use uppercase hexadecimal digits for percent-encoding

Brian Moran 356 June 27, 2014 02:06PM

Re: [PATCH] Core: use uppercase hexadecimal digits for percent-encoding

Valentin V. Bartenev 307 June 30, 2014 08:42AM

Re: [PATCH] Core: use uppercase hexadecimal digits for percent-encoding

Maxim Dounin 316 June 30, 2014 09:16PM

Re: [PATCH] Core: use uppercase hexadecimal digits for percent-encoding

Piotr Sikora 356 June 30, 2014 05:02PM

Re: [PATCH] Core: use uppercase hexadecimal digits for percent-encoding

Maxim Dounin 382 June 30, 2014 09:06PM

Re: [PATCH] Core: use uppercase hexadecimal digits for percent-encoding

Yichun Zhang (agentzh) 274 June 30, 2014 07:26PM

Re: [PATCH] Core: use uppercase hexadecimal digits for percent-encoding

Maxim Dounin 352 June 30, 2014 09:14PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 295
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready