Welcome! Log In Create A New Profile

Advanced

[nginx] Upstream: no need to clear r->headers_out.last_modified_...

Maxim Dounin
June 25, 2014 06:42PM
details: http://hg.nginx.org/nginx/rev/c8bdde1c8c97
branches:
changeset: 5730:c8bdde1c8c97
user: Maxim Dounin <mdounin@mdounin.ru>
date: Thu Jun 26 02:19:58 2014 +0400
description:
Upstream: no need to clear r->headers_out.last_modified_time.

Clearing of the r->headers_out.last_modified_time field if a response
isn't cacheable in ngx_http_upstream_send_response() was introduced
in 3b6afa999c2f, the commit to enable not modified filter for cacheable
responses. It doesn't make sense though, as at this point header was
already sent, and not modified filter was already executed. Therefore,
the line was removed to simplify code.

diffstat:

src/http/ngx_http_upstream.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diffs (11 lines):

diff --git a/src/http/ngx_http_upstream.c b/src/http/ngx_http_upstream.c
--- a/src/http/ngx_http_upstream.c
+++ b/src/http/ngx_http_upstream.c
@@ -2500,7 +2500,6 @@ ngx_http_upstream_send_response(ngx_http

} else {
u->cacheable = 0;
- r->headers_out.last_modified_time = -1;
}
}


_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[nginx] Upstream: no need to clear r->headers_out.last_modified_...

Maxim Dounin 355 June 25, 2014 06:42PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 129
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready