details: http://hg.nginx.org/nginx/rev/5a65b9d8bc2b
branches:
changeset: 5637:5a65b9d8bc2b
user: Maxim Dounin <mdounin@mdounin.ru>
date: Mon Mar 31 22:47:42 2014 +0400
description:
Adjusted default value of types_hash_bucket_size (ticket #352).

The ngx_cacheline_size may be too low on some platforms, resulting
in unexpected hash build problems (as no collisions are tolerated due
to low bucket_size, and max_size isn't big enough to build a hash without
collisions). These problems aren't fatal anymore but nevertheless
need to be addressed.

diffstat:

src/http/ngx_http_core_module.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diffs (13 lines):

diff --git a/src/http/ngx_http_core_module.c b/src/http/ngx_http_core_module.c
--- a/src/http/ngx_http_core_module.c
+++ b/src/http/ngx_http_core_module.c
@@ -3710,8 +3710,7 @@ ngx_http_core_merge_loc_conf(ngx_conf_t
prev->types_hash_max_size, 1024);

ngx_conf_merge_uint_value(conf->types_hash_bucket_size,
- prev->types_hash_bucket_size,
- ngx_cacheline_size);
+ prev->types_hash_bucket_size, 64);

conf->types_hash_bucket_size = ngx_align(conf->types_hash_bucket_size,
ngx_cacheline_size);

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel