Welcome! Log In Create A New Profile

Advanced

[nginx] SPDY: alert about activated fake events instead of delet...

Valentin Bartenev
August 15, 2013 11:20AM
details: http://hg.nginx.org/nginx/rev/abf7813b927e
branches:
changeset: 5325:abf7813b927e
user: Valentin Bartenev <vbart@nginx.com>
date: Thu Aug 15 19:16:12 2013 +0400
description:
SPDY: alert about activated fake events instead of deleting them.

They refer to the same socket descriptor as our real connection, and
deleting them will stop processing of the connection.

Events of fake connections must not be activated, and if it happened there
is nothing we can do. The whole processing should be terminated as soon as
possible, but it is not obvious how to do this safely.

diffstat:

src/http/ngx_http_spdy.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)

diffs (23 lines):

diff -r 8ef1722143dc -r abf7813b927e src/http/ngx_http_spdy.c
--- a/src/http/ngx_http_spdy.c Thu Aug 15 19:16:09 2013 +0400
+++ b/src/http/ngx_http_spdy.c Thu Aug 15 19:16:12 2013 +0400
@@ -2663,7 +2663,8 @@ ngx_http_spdy_close_stream(ngx_http_spdy
ev = fc->read;

if (ev->active || ev->disabled) {
- ngx_del_event(ev, NGX_READ_EVENT, 0);
+ ngx_log_error(NGX_LOG_ALERT, sc->connection->log, 0,
+ "spdy fake read event was activated");
}

if (ev->timer_set) {
@@ -2677,7 +2678,8 @@ ngx_http_spdy_close_stream(ngx_http_spdy
ev = fc->write;

if (ev->active || ev->disabled) {
- ngx_del_event(ev, NGX_WRITE_EVENT, 0);
+ ngx_log_error(NGX_LOG_ALERT, sc->connection->log, 0,
+ "spdy fake write event was activated");
}

if (ev->timer_set) {

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[nginx] SPDY: alert about activated fake events instead of delet...

Valentin Bartenev 602 August 15, 2013 11:20AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 171
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 500 on July 15, 2024
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready