Welcome! Log In Create A New Profile

Advanced

[PATCH] ngx_mail_http_auth_module

Filipe Da Silva
May 02, 2013 10:02AM
Hello, Nginx developers,

I been working recently on NGinx, as part of my job .

And I see some small issues as this one :

This call to *ngx_close_connection* is useless as it was already made 18
lines before in the code .
Same code is present in 1.2

Regards,
Filipe

----

diff -r 8222ca034980 src/mail/ngx_mail_auth_http_module.c
--- a/src/mail/ngx_mail_auth_http_module.c Tue Apr 02 12:34:39 2013 +0000
+++ b/src/mail/ngx_mail_auth_http_module.c Thu May 02 15:46:42 2013 +0200
@@ -696,7 +696,6 @@

p = ngx_pnalloc(s->connection->pool, ctx->err.len);
if (p == NULL) {
- ngx_close_connection(ctx->peer.connection);
ngx_destroy_pool(ctx->pool);
ngx_mail_session_internal_server_error(s);
return;
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] ngx_mail_http_auth_module

Filipe Da Silva 846 May 02, 2013 10:02AM

Re: [PATCH] ngx_mail_http_auth_module

Valentin V. Bartenev 399 May 08, 2013 10:24AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 217
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 500 on July 15, 2024
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready