Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Fix a memory invalid read issue in ngx_http_gzip_ok

Maxim Dounin
December 22, 2011 08:22AM
Hello!

On Thu, Dec 22, 2011 at 08:18:41PM +0800, agentzh wrote:

> On Thu, Dec 22, 2011 at 5:00 PM, Maxim Dounin <mdounin@mdounin.ru> wrote:
> > I suppose the problem is instead in your code which (incorrectly)
> > adds headers to r->headers_in.
> >
>
> I do strongly suggest we *should* support manipulating request
> headers, it's often desired by many people in real world settings :)

As I already said more than once, I don't think we should. If
it's needed - it means something else needs fixing. We do support
arbitrary modification of headers passed to upstream servers, and
this should be enough.

But, actually, nobody stops you from adding headers correctly,
i.e. null-terminated.

Maxim Dounin

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Fix a memory invalid read issue in ngx_http_gzip_ok Attachments

agentzh 1301 December 21, 2011 10:20PM

Re: [PATCH] Fix a memory invalid read issue in ngx_http_gzip_ok

Maxim Dounin 470 December 22, 2011 04:02AM

Re: [PATCH] Fix a memory invalid read issue in ngx_http_gzip_ok

agentzh 450 December 22, 2011 07:20AM

Re: [PATCH] Fix a memory invalid read issue in ngx_http_gzip_ok

Maxim Dounin 415 December 22, 2011 08:22AM

Re: [PATCH] Fix a memory invalid read issue in ngx_http_gzip_ok

agentzh 475 December 22, 2011 08:38AM

Re: [PATCH] Fix a memory invalid read issue in ngx_http_gzip_ok

Maxim Dounin 470 December 22, 2011 10:18AM

Re: [PATCH] Fix a memory invalid read issue in ngx_http_gzip_ok

agentzh 614 December 23, 2011 06:12AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 304
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready