Welcome! Log In Create A New Profile

Advanced

Re: Bug in request.headers_out initialization?

November 23, 2011 11:42AM
On Wed, Nov 23, 2011 at 10:04:06PM +0530, Fasih wrote:
> Hi
>
> I have a plugin that uses request.headers_out.headers, I use the
> lowcase_key of the element for something. However, recently while debugging
> a crash I noticed that the lowcase_key isnt always initialized
> [e.g. src/http/modules/ngx_http_userid_filter_module.c:424,
> set_cookie->lowcase_key isnt set(nor initialized)] I would have taken that
> as a bug but noticed that there are other places
> [src/http/modules/ngx_http_headers_filter_module.c] where lowcase_key isnt
> initialized. However, in all the three instances, header.hash is
> initialized to 1.
>
> So, the question is:
> 1. Does hash = 1 necessarily imply that lowcase_key isnt initialized?
> 2. Should lowcase_key have been initialized and this is a bug [in which
> case I can walk through the code and submit a patch]
> 3. Why is this done?

lowcase_key is used in r->headers_in only to find them in headers_in_hash.


--
Igor Sysoev

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

Bug in request.headers_out initialization?

faskiri.devel 1770 November 23, 2011 11:36AM

Re: Bug in request.headers_out initialization?

Igor Sysoev 923 November 23, 2011 11:42AM

Re: Bug in request.headers_out initialization?

Fasihullah Askiri 660 November 23, 2011 11:50AM

Re: Bug in request.headers_out initialization?

Igor Sysoev 892 November 23, 2011 11:52AM

Re: Bug in request.headers_out initialization?

Fasihullah Askiri 696 November 23, 2011 12:04PM

Re: Bug in request.headers_out initialization?

Igor Sysoev 830 November 23, 2011 12:10PM

Re: Bug in request.headers_out initialization?

faskiri.devel 739 November 23, 2011 12:30PM

Re: Bug in request.headers_out initialization?

Igor Sysoev 994 November 23, 2011 01:52PM

Re: Bug in request.headers_out initialization?

faskiri.devel 852 November 24, 2011 12:08AM

Re: Bug in request.headers_out initialization?

Igor Sysoev 922 November 24, 2011 03:20AM

Re: Bug in request.headers_out initialization?

faskiri.devel 876 November 24, 2011 04:56AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 98
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 500 on July 15, 2024
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready