Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Ignore response header entries with zero hash in ngx_http_varaible_headers

agentzh
September 30, 2011 02:10PM
On Fri, Sep 30, 2011 at 9:05 AM, Maxim Dounin <mdounin@mdounin.ru> wrote:
>
> It looks like this particular case affects
> $sent_http_cache_control only.
>

It seems :)

> Though it looks like similar issue exists in
> ngx_http_variable_unknown_header(), it should be fixed
> too.  Quick look suggests in vanilla nginx it may affect
> $sent_http_accept_ranges, $sent_http_refresh,
> $sent_http_www_authenticate and probably other headers.
>

Indeed, this one affects user custom response headers too :)

> Could you please take a closer look and provide patch which fixes
> this one too?
>

Sure. The fix is already included in the updated version of my patch
attached to this email.

> And see below for review.
>

Thank you for the review. I've already updated the patch per your
suggestion and tested on my side :)

Best,
-agentzh
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Ignore response header entries with zero hash in ngx_http_varaible_headers Attachments

agentzh 2495 September 29, 2011 03:08PM

Re: [PATCH] Ignore response header entries with zero hash in ngx_http_varaible_headers

rogergue 938 September 29, 2011 04:00PM

Re: [PATCH] Ignore response header entries with zero hash in ngx_http_varaible_headers

rogergue 904 September 29, 2011 04:14PM

Re: [PATCH] Ignore response header entries with zero hash in ngx_http_varaible_headers

rogergue 870 September 29, 2011 04:18PM

Re: [PATCH] Ignore response header entries with zero hash in ngx_http_varaible_headers

Maxim Dounin 802 September 30, 2011 12:06PM

Re: [PATCH] Ignore response header entries with zero hash in ngx_http_varaible_headers Attachments

agentzh 853 September 30, 2011 02:10PM

Re: [PATCH] Ignore response header entries with zero hash in ngx_http_varaible_headers Attachments

agentzh 822 November 09, 2011 04:50AM

Re: [PATCH] Ignore response header entries with zero hash in ngx_http_varaible_headers

Valentin V. Bartenev 718 December 06, 2011 03:44AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 74
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready