Welcome! Log In Create A New Profile

Advanced

Re: segfault in 1.1.4

Jérôme Loyet
September 22, 2011 03:08AM
2011/9/22 Maxim Dounin <mdounin@mdounin.ru>:
> Hello!
>
> On Wed, Sep 21, 2011 at 01:58:02PM +0200, Jérôme Loyet wrote:
>
>> 2011/9/21 Maxim Dounin <mdounin@mdounin.ru>:
>> > Hello!
>> >
>> > On Wed, Sep 21, 2011 at 01:05:49PM +0200, Jérôme Loyet wrote:
>> >
>> >> Hi,
>> >>
>> >> after migrating to 1.1.4 from 1.0.4, nginx would segfault on some cases.
>> >>
>> >> I've tracked down the problem to a double free in the upstream module.
>> >> Here is a patch. I don't know if it's the right solution to fix this:
>
> [...]
>
>> > It looks like this resulted in "connection
>> > already closed" alerts previously and may resulted in problems
>> > with ssl upstream connections (up to similar segmentation faults).
>> >
>> > Better patch would be
>>
>> yes you are right, this patch is much better. I've just tried it and
>> it works well.
>
> Ok, thanks for testing.
>
> BTW, just to clarify things: are you using upstream fair or some
> other 3rd party balancer module?

I'm using 3rd party balancer module. I should maybe set pc->connection to NULL

>
> Both standard balancers (round-robin and ip hash) explicitly set
> pc->connection (i.e. u->peer.connection) to NULL and this will
> never happen.
>
> Maxim Dounin
>
> _______________________________________________
> nginx-devel mailing list
> nginx-devel@nginx.org
> http://mailman.nginx.org/mailman/listinfo/nginx-devel

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

segfault in 1.1.4

Jérôme Loyet 1700 September 21, 2011 07:06AM

Re: segfault in 1.1.4

Maxim Dounin 580 September 21, 2011 07:52AM

Re: segfault in 1.1.4

Jérôme Loyet 604 September 21, 2011 08:00AM

Re: segfault in 1.1.4

Maxim Dounin 554 September 21, 2011 09:22PM

Re: segfault in 1.1.4

Jérôme Loyet 729 September 22, 2011 03:08AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 155
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready