Welcome! Log In Create A New Profile

Advanced

Re: GeoIPv6 patch

June 11, 2011 02:22PM
Hi.

On Saturday 11 of June 2011 16:54:18 you wrote:
> Unrelated whitespace breakage. There are multiple other style
> issues, too.

There souldn't be any now in this patch.


> I don't really like this aproach. Result looks to cluttered with
> #if's and hard to read. Probably it's good idea to try to produce
> something better.

Put one #if .. #endif block at the begining. Not sure if it's good enough
(does inherit compile errors, but makes two identical pathways)...

> Using inet_ntop/sprintf/inet_pton to map ipv4 binary address to
> ipv4-mapped ipv6 binary address is cool. :)
>
> What about just setting appropriate bytes?

Now using binary operators :).


> It's probably good idea to centralize all these checks at
> configuration stage.
>
> Please also note that nginx style is to use 4 spaces for
> indentation, and always use {}.

I added three variables to configure struct (is_<type>_ipv6).


> Some configure checks for ipv6 support in libgeoip may also be
> needed as I have no idea if recent libgeoip versions are widely
> availabe on some known-to-be-slow Linux'es. Not sure, but it at
> least deserves some investigation.
>
> Maxim Dounin

Added a check into auto/unix. Check for availability of database type names.

Best regards,
Gregor Kališnik_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

GeoIPv6 patch

MasterMind2k 2954 June 11, 2011 04:36AM

Re: GeoIPv6 patch

Arnaud GRANAL 976 June 11, 2011 06:12AM

Re: GeoIPv6 patch

MasterMind2k 1275 June 11, 2011 06:50AM

Re: GeoIPv6 patch

Maxim Dounin 1034 June 11, 2011 08:56AM

Re: GeoIPv6 patch

MasterMind2k 1293 June 11, 2011 02:22PM

Re: GeoIPv6 patch

MasterMind2k 1291 June 14, 2011 01:54AM

Re: GeoIPv6 patch

Maxim Dounin 907 June 14, 2011 07:48PM

Re: GeoIPv6 patch

MasterMind2k 1340 June 15, 2011 06:46AM

Re: GeoIPv6 patch

Maxim Dounin 991 June 21, 2011 12:54PM

Re: GeoIPv6 patch

MasterMind2k 1301 June 21, 2011 05:14PM

Re: GeoIPv6 patch

Maxim Dounin 1026 June 21, 2011 05:46PM

Re: GeoIPv6 patch

MasterMind2k 1541 June 22, 2011 04:40AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 111
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 500 on July 15, 2024
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready