Welcome! Log In Create A New Profile

Advanced

Re: [Patch][GeoIP][1.0.0] GeoIP Organization / ISP support

April 18, 2011 02:22PM
On Mon, Apr 18, 2011 at 05:56:09PM +0300, Arnaud GRANAL wrote:
> Igor Sysoev wrote:
> > There is already patch to support GeoIP ISP base:
> > http://kornel.neolabs.kz/files/nginx-0.9.7-geoip-isp.patch.bz2
>
> > What is the difference between ISP base and Organization base ?
>
> Almost none, organization is more precise but API calls are the same.
> As far I can see the code is very similar so there is no reason to use my patch.

To get GeoIP_1st patch calls GeoIP_name_by_ipnum(),
while your patch calls GeoIP_org_by_ipnum() to get organization.
Do these capabilities exist in both bases ?

> I didn't see that this patch exist so I spent a little bit time coding myself,
> to save some time to other people could you consider putting the 0.9.7 patch into main tree ?

This patch was in Russian mailing list so you did not see it.
I think it's better to combine ISP and organization capability.


--
Igor Sysoev

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[Patch][GeoIP][1.0.0] GeoIP Organization / ISP support

Arnaud GRANAL 3556 April 18, 2011 09:48AM

Re: [Patch][GeoIP][1.0.0] GeoIP Organization / ISP support

Arnaud GRANAL 947 April 18, 2011 09:50AM

Re: [Patch][GeoIP][1.0.0] GeoIP Organization / ISP support

Igor Sysoev 1115 April 18, 2011 10:04AM

Re: [Patch][GeoIP][1.0.0] GeoIP Organization / ISP support

Arnaud GRANAL 981 April 18, 2011 10:58AM

Re: [Patch][GeoIP][1.0.0] GeoIP Organization / ISP support

Igor Sysoev 1082 April 18, 2011 02:22PM

Re: [Patch][GeoIP][1.0.0] GeoIP Organization / ISP support

Arnaud GRANAL 1276 April 18, 2011 02:46PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 174
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 500 on July 15, 2024
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready