Welcome! Log In Create A New Profile

Advanced

Re: Patch: avoid multiple vary header entries

Maxim Dounin
April 11, 2011 09:50AM
Hello!

On Mon, Apr 11, 2011 at 02:54:21PM +0200, Daniel Bornkessel wrote:

> Hi, while using nginx & varnish together we had problems when
> setting a 'Vary' header in our app when nginx is configured with
>
> gzip_vary on;
>
> as nginx's created response contain two 'Vary' header entries:
>
> Vary: Accept-Encoding
> Vary: X-Special
>
> however, several clients, including Varnish, don't understand
> this. Instead they need one header entry:
>
> Vary: Accept-Encoding, X-Special

Just a side note: per RFC2616 these forms are equivalent.
http://tools.ietf.org/html/rfc2616#section-4.2

> this is a patch that achieves this behavior. Is there any chance
> getting this patch into upstream?

The patch doesn't looks correct for me. While it probably works,
it certainly does many unneeded things and violates at least one
invariant concerning r->headers_out.

Maxim Dounin

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

Patch: avoid multiple vary header entries Attachments

Daniel Bornkessel 3049 April 11, 2011 09:16AM

Re: Patch: avoid multiple vary header entries

Maxim Dounin 1134 April 11, 2011 09:50AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 106
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready