Welcome! Log In Create A New Profile

Re: [PATCH] Add autoindex_css_file option

Forum List Message List New Topic Print View

Clément Bœsch

February 23, 2011 04:22AM

On Mon, Feb 21, 2011 at 02:00:04PM +0300, Maxim Dounin wrote:
> Hello!
>
> On Mon, Feb 21, 2011 at 01:20:27AM +0100, Clément Bœsch wrote:
>
> > On Mon, Feb 21, 2011 at 03:08:18AM +0300, Maxim Dounin wrote:
> > > Hello!
> > >
> > > On Sun, Feb 20, 2011 at 09:47:37PM +0100, Clément Bœsch wrote:
> > >
> > > [...]
> > >
> > > > static u_char title[] =
> > > > -"<html>" CRLF
> > > > +"<!DOCTYPE html>" CRLF
> > > > "<head><title>Index of "
> > > > ;
> > >
> > > The result isn't html at all.
> > >
> >
> > Well it's HTML5…
>
> No it isn't. You dropped html element.
>

My bad, it didn't look mandatory for the w3c validator: "<!doctype
html><head><title></title></head></html>" seems to be the minimum, but
I'll definitely update the patch.

> Please note that there is also other issues with you patches, you
> may want spend some more time on them before posting again.
>

Could you be a bit more explicit? What are the issues?

Regards,

--
Clément B.
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://nginx.org/mailman/listinfo/nginx-devel

Reply Quote

RSS

Subject	Author	Views	Posted
[PATCH] Add autoindex_css_file option	Clément Bœsch	4010	February 20, 2011 12:04PM
Re: [PATCH] Add autoindex_css_file option	Clément Bœsch	950	February 20, 2011 12:10PM
Re: [PATCH] Add autoindex_css_file option	Maxim Dounin	928	February 20, 2011 01:26PM
Re: [PATCH] Add autoindex_css_file option	Clément Bœsch	875	February 20, 2011 03:48PM
Re: [PATCH] Add autoindex_css_file option	Maxim Dounin	909	February 20, 2011 07:10PM
Re: [PATCH] Add autoindex_css_file option	Clément Bœsch	967	February 20, 2011 07:22PM
Re: [PATCH] Add autoindex_css_file option	Maxim Dounin	1069	February 21, 2011 06:02AM
Re: [PATCH] Add autoindex_css_file option	Adrian Perez	979	February 21, 2011 07:40AM
Re: [PATCH] Add autoindex_css_file option	Clément Bœsch	918	February 23, 2011 04:22AM
Re: [PATCH] Add autoindex_css_file option	Clément Bœsch	1183	March 03, 2011 07:58PM

Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 277

Record Number of Users: 8 on April 13, 2023

Record Number of Guests: 421 on December 02, 2018