Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] allow keep-alive to safari when it's ok

February 11, 2011 02:48AM
On Thu, Feb 10, 2011 at 07:05:57PM -0800, Naoki Hiroshima wrote:
> Hi,
>
> The workaround for safari/keep-alive issue being introduced by 0.8.33
> seems to be way too aggressive. Since it's a POST issue, we should
> unwillingly disable keep-alive only when it's POST.

Please read this:
https://bugs.webkit.org/show_bug.cgi?id=5760
The problem is that keepalive should be disable before Safari issues POST.

BTW, keepalive_disable directive has been introduced in 0.9.0.
It has "none", "msie6", "safari" options.

> -- @N
>
> $ diff -u src/http/ngx_http_core_module.c~ src/http/ngx_http_core_module.c
> --- src/http/ngx_http_core_module.c~ 2010-12-14 10:38:42.000000000 +0000
> +++ src/http/ngx_http_core_module.c 2011-02-11 02:55:05.000000000 +0000
> @@ -802,11 +802,13 @@
> }
>
> } else if (r->headers_in.safari) {
> - /*
> - * Safari may send a POST request to a closed keepalive
> - * connection and stalls for some time
> - */
> - r->keepalive = 0;
> + if (r->method == NGX_HTTP_POST) {
> + /*
> + * Safari may send a POST request to a closed keepalive
> + * connection and stalls for some time
> + */
> + r->keepalive = 0;
> + }
> }
> }


--
Igor Sysoev
http://sysoev.ru/en/

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] allow keep-alive to safari when it's ok

Naoki Hiroshima 2956 February 10, 2011 10:08PM

Re: [PATCH] allow keep-alive to safari when it's ok

Igor Sysoev 1008 February 11, 2011 02:48AM

Re: [PATCH] allow keep-alive to safari when it's ok

Naoki Hiroshima 861 February 11, 2011 06:58PM

Re: [PATCH] allow keep-alive to safari when it's ok

agentzh 773 February 11, 2011 10:18PM

Re: [PATCH] allow keep-alive to safari when it's ok

Igor Sysoev 937 February 12, 2011 01:44AM

Re: [PATCH] allow keep-alive to safari when it's ok

Peter Leonov 1082 February 13, 2011 12:56PM

Re: [PATCH] allow keep-alive to safari when it's ok

Igor Sysoev 972 February 12, 2011 01:42AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 143
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 500 on July 15, 2024
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready