Welcome! Log In Create A New Profile

[PATCH] allow keep-alive to safari when it's ok

Forum List Message List New Topic Print View

Naoki Hiroshima

February 10, 2011 10:08PM

Hi,

The workaround for safari/keep-alive issue being introduced by 0.8.33
seems to be way too aggressive. Since it's a POST issue, we should
unwillingly disable keep-alive only when it's POST.

-- @N

$ diff -u src/http/ngx_http_core_module.c~ src/http/ngx_http_core_module.c
--- src/http/ngx_http_core_module.c~ 2010-12-14 10:38:42.000000000 +0000
+++ src/http/ngx_http_core_module.c 2011-02-11 02:55:05.000000000 +0000
@@ -802,11 +802,13 @@
}

} else if (r->headers_in.safari) {
- /*
- * Safari may send a POST request to a closed keepalive
- * connection and stalls for some time
- */
- r->keepalive = 0;
+ if (r->method == NGX_HTTP_POST) {
+ /*
+ * Safari may send a POST request to a closed keepalive
+ * connection and stalls for some time
+ */
+ r->keepalive = 0;
+ }
}
}

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://nginx.org/mailman/listinfo/nginx-devel

Reply Quote

RSS

Subject	Author	Views	Posted
[PATCH] allow keep-alive to safari when it's ok	Naoki Hiroshima	2958	February 10, 2011 10:08PM
Re: [PATCH] allow keep-alive to safari when it's ok	Igor Sysoev	1028	February 11, 2011 02:48AM
Re: [PATCH] allow keep-alive to safari when it's ok	Naoki Hiroshima	868	February 11, 2011 06:58PM
Re: [PATCH] allow keep-alive to safari when it's ok	agentzh	774	February 11, 2011 10:18PM
Re: [PATCH] allow keep-alive to safari when it's ok	Igor Sysoev	957	February 12, 2011 01:44AM
Re: [PATCH] allow keep-alive to safari when it's ok	Peter Leonov	1085	February 13, 2011 12:56PM
Re: [PATCH] allow keep-alive to safari when it's ok	Igor Sysoev	991	February 12, 2011 01:42AM