> On 20 Dec 2022, at 17:30, Maxim Dounin <mdounin@mdounin.ru> wrote:
>
> # HG changeset patch
> # User Maxim Dounin <mdounin@mdounin.ru>
> # Date 1671541078 -10800
> # Tue Dec 20 15:57:58 2022 +0300
> # Node ID 43098cb134a87a404b70fcc77ad01ca343cba969
> # Parent f5d9c24fb4ac2a6b82b9d842b88978a329690138
> Win32: handling of localized MSVC cl output.
>
> Output examples in English, Russian, and Spanish:
>
> Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 16.00.30319.01 for 80x86
> Оптимизирующий 32-разрядный компилятор Microsoft (R) C/C++ версии 16.00.30319.01 для 80x86
> Compilador de optimización de C/C++ de Microsoft (R) versión 16.00.30319.01 para x64
>

The transaction to import this change with mercurial on a non-localized
win2003 aborts with the error:

abort: decoding near '....': 'charmap' codec can't decode byte 0x8f in position 218: character maps to <undefined>!

The position matches UTF-8 U+044F (0xd18f), Cyrillic small letter ya:
$ hg ex --template {desc} | hexdump -C | grep `printf "%08x\n" $((218/16*16))`
000000d0 2d d1 80 d0 b0 d0 b7 d1 80 d1 8f d0 b4 d0 bd d1 |-?.аз?.?.дн?|

Although the error can be suppressed using HGENCODING, "hg log"
produces garbled output in place of Cyrillic and umlaut symbols.

The safest solution can be to mangle such localized examples in ascii,
to allow the change to apply and still have a sketchy knowledge how cl
output can be different. Another way is to skip the examples.

> Since most of the words are translated, instead of looking for the words
> "Compiler Version" we now search for "C/C++" and the version number.
>
> diff -r f5d9c24fb4ac -r 43098cb134a8 auto/cc/msvc
> --- a/auto/cc/msvc Tue Dec 20 15:57:51 2022 +0300
> +++ b/auto/cc/msvc Tue Dec 20 15:57:58 2022 +0300
> @@ -11,8 +11,8 @@
> # MSVC 2015 (14.0) cl 19.00
>
>
> -NGX_MSVC_VER=`$NGX_WINE $CC 2>&1 | grep 'Compiler Version' 2>&1 \
> - | sed -e 's/^.* Version \(.*\)/\1/'`
> +NGX_MSVC_VER=`$NGX_WINE $CC 2>&1 | grep 'C/C++.* [0-9][0-9]*\.[0-9]' 2>&1 \
> + | sed -e 's/^.* \([0-9][0-9]*\.[0-9].*\)/\1/'`
>
> echo " + cl version: $NGX_MSVC_VER"
>

I recall there were discussions whether we can avoid using the grep command,
or if it should search other words for better matching.
Personally, I think the proposed change is good enough.

--
Sergey Kandaurov
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel