Welcome! Log In Create A New Profile

Advanced

Re: Fix nginx for build with any version of openssl.

Maxim Dounin
January 10, 2011 07:12PM
Hello!

On Mon, Jan 10, 2011 at 11:45:26PM +0300, Kirill A. Korinskiy wrote:

> Fix nginx for build with any version of openssl.
>
> Format of openssl version is MNNFFPPS: major minor fix patch status
> The status nibble has one of the values 0 for development, 1 to e for betas
> 1 to 14, and f for release. The patch level is exactly that.

Missing part in your patch comment is when the interface change in
question ("const" qualifier in SSL_get_current_cipher()'s return
type and other places) was introduced.

It was introduced here:

http://cvs.openssl.org/chngview?cn=17503
2008-Oct-12 14:32:38 (UTC)

at that time version in openssl's HEAD was 0x00909000L, and it was
bumped to 0x10000000L here:

http://cvs.openssl.org/chngview?cn=17927
2009-Mar-28 17:12:50 (UTC)

There were no version bump for the interface change in question,
so you really can't make nginx buildable with *any* version with
this aproach. Though checking for 0x10000000L is indeed ok, it
will make nginx buildable with openssl 1.0.0-beta[12345] without
breaking anything.

Maxim Dounin

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

Fix nginx for build with any version of openssl.

Kirill A. Korinskiy 2483 January 10, 2011 03:46PM

Re: Fix nginx for build with any version of openssl.

Maxim Dounin 894 January 10, 2011 07:12PM

Re: Fix nginx for build with any version of openssl.

Kirill A. Korinskiy 884 January 10, 2011 08:12PM

Re: Fix nginx for build with any version of openssl.

Maxim Dounin 940 January 10, 2011 08:56PM

Re: Fix nginx for build with any version of openssl.

Kirill A. Korinskiy 931 January 11, 2011 05:48AM

Re: Fix nginx for build with any version of openssl.

Maxim Dounin 978 January 11, 2011 07:26AM

Re: Fix nginx for build with any version of openssl.

Kirill A. Korinskiy 1104 January 11, 2011 08:04AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 246
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 500 on July 15, 2024
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready