Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Allow binary upgrades in Solaris zones

Anonymous User
January 06, 2011 11:24AM
Hi Piotr,

I tested your patch and it does in fact work for me (thank you).

On Wed, Jan 05, 2011 at 09:14:48PM +0100 or thereabouts, Piotr Sikora wrote:
> 1) You are introducing unnecessary function call for all users, this new
> code-path should be evaluated only for Solaris users.

Personally I wouldn't worry about this because it is not on a "hot path"
although your approach looks fine too.

> 2) You are assuming that nginx is running as root, which isn't always true.

True. This was necessary because non-root processes can never send signals to
init so the test is meaningless if you are not root.

My only issue with your approach of using getzoneid() is that I'm afraid it may
break compilation on Solaris versions prior to 10 although I have no way to test
this.

Doug Hoyte

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Allow binary upgrades in Solaris zones

Anonymous User 1908 January 05, 2011 02:24PM

Re: [PATCH] Allow binary upgrades in Solaris zones Attachments

Piotr Sikora 711 January 05, 2011 03:16PM

Re: [PATCH] Allow binary upgrades in Solaris zones Attachments

Piotr Sikora 787 January 05, 2011 03:28PM

Re: [PATCH] Allow binary upgrades in Solaris zones

Anonymous User 586 January 06, 2011 11:24AM

Re: [PATCH] Allow binary upgrades in Solaris zones

Piotr Sikora 559 January 06, 2011 07:40PM

Re: [PATCH] Allow binary upgrades in Solaris zones

Maxim Dounin 609 January 05, 2011 06:54PM

Re: [PATCH] Allow binary upgrades in Solaris zones

Anonymous User 606 January 06, 2011 11:46AM

Re: [PATCH] Allow binary upgrades in Solaris zones

Maxim Dounin 686 January 06, 2011 10:00PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 229
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready