Welcome! Log In Create A New Profile

Advanced

[nginx] Core: silenced getsockopt(TCP_FASTOPEN) messages on FreeBSD.

Maxim Dounin
May 22, 2018 10:00AM
details: http://hg.nginx.org/nginx/rev/66aa2c1e82e6
branches:
changeset: 7274:66aa2c1e82e6
user: Maxim Dounin <mdounin@mdounin.ru>
date: Mon May 21 23:11:27 2018 +0300
description:
Core: silenced getsockopt(TCP_FASTOPEN) messages on FreeBSD.

FreeBSD returns EINVAL when getsockopt(TCP_FASTOPEN) is called on a unix
domain socket, resulting in "getsockopt(TCP_FASTOPEN) ... failed" messages
during binary upgrade when unix domain listen sockets are present in
the configuration. Added EINVAL to the list of ignored error codes.

diffstat:

src/core/ngx_connection.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diffs (14 lines):

diff --git a/src/core/ngx_connection.c b/src/core/ngx_connection.c
--- a/src/core/ngx_connection.c
+++ b/src/core/ngx_connection.c
@@ -305,7 +305,9 @@ ngx_set_inherited_sockets(ngx_cycle_t *c
{
err = ngx_socket_errno;

- if (err != NGX_EOPNOTSUPP && err != NGX_ENOPROTOOPT) {
+ if (err != NGX_EOPNOTSUPP && err != NGX_ENOPROTOOPT
+ && err != NGX_EINVAL)
+ {
ngx_log_error(NGX_LOG_NOTICE, cycle->log, err,
"getsockopt(TCP_FASTOPEN) %V failed, ignored",
&ls[i].addr_text);
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[nginx] Core: silenced getsockopt(TCP_FASTOPEN) messages on FreeBSD.

Maxim Dounin 436 May 22, 2018 10:00AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 234
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready