Welcome! Log In Create A New Profile

Advanced

[PATCH] Unix: remove errno logging when send() returned zero.

Jianjun Zheng
June 09, 2014 12:56PM
When send() returned zero, the errno won't be set.
So, it's meaningless here.

# HG changeset patch
# User Jianjun Zheng <codeeply@gmail.com>
# Date 1402330476 -28800
# Tue Jun 10 00:14:36 2014 +0800
# Node ID 77e5822468c8619dcc3c7ad35f906763d34292a1
# Parent 7f425d67f91ae3966b4f31b33dcd0386977a97a4
Unix: remove errno logging when send() returned zero.

diff -r 7f425d67f91a -r 77e5822468c8 src/os/unix/ngx_send.c
--- a/src/os/unix/ngx_send.c Tue Jun 03 10:53:48 2014 -0700
+++ b/src/os/unix/ngx_send.c Tue Jun 10 00:14:36 2014 +0800
@@ -46,14 +46,14 @@
return n;
}

- err = ngx_socket_errno;
-
if (n == 0) {
- ngx_log_error(NGX_LOG_ALERT, c->log, err, "send() returned
zero");
+ ngx_log_error(NGX_LOG_ALERT, c->log, 0, "send() returned
zero");
wev->ready = 0;
return n;
}

+ err = ngx_socket_errno;
+
if (err == NGX_EAGAIN || err == NGX_EINTR) {
wev->ready = 0;
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Unix: remove errno logging when send() returned zero.

Jianjun Zheng 640 June 09, 2014 12:56PM

Re: [PATCH] Unix: remove errno logging when send() returned zero.

Maxim Dounin 285 June 10, 2014 07:38AM

Re: [PATCH] Unix: remove errno logging when send() returned zero.

Jianjun Zheng 264 June 10, 2014 08:04AM

Re: [PATCH] Unix: remove errno logging when send() returned zero.

Maxim Dounin 394 June 10, 2014 08:06AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 62
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready