Welcome! Log In Create A New Profile

Advanced

it seems a bug in ngx_http_gzip_disable function.

jin huang
October 11, 2010 12:56AM
Hello everyone,

In ngx_http_gzip_disable function of http/ngx_http_core_module.c,
The code is here:
http://www.google.com/codesearch/p?hl=en#N6mCnE4lf5g/src/http/ngx_http_core_module.c&q=http_gzip_disable%20package:nginx&sa=N&cd=1&ct=rc&l=73Line
4387-4392:

for (i = 1; i < cf->args->nelts; i++) { if
(ngx_strcmp(value[1].data, "msie6") == 0) {
clcf->gzip_disable_msie6 = 1; continue; }

It used value[1] to compare with "msie6", which I think "1" is a misspell of
"i". If it is indeed 1, then I think maybe the if statement should be
located outside the for loop.

Thank you for taking the time to read.

Best regards.

hank
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

it seems a bug in ngx_http_gzip_disable function.

jin huang 1930 October 11, 2010 12:56AM

Re: it seems a bug in ngx_http_gzip_disable function.

Igor Sysoev 877 October 11, 2010 01:00AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 83
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready