Welcome! Log In Create A New Profile

Advanced

Re: nginx-0.7.49

Maxim Dounin
April 06, 2009 11:23AM
Hello!

On Mon, Apr 06, 2009 at 03:44:49PM +0400, Igor Sysoev wrote:

[...]

> > Disregard this. It should be
> >
> > diff --git a/src/core/ngx_string.c b/src/core/ngx_string.c
> > --- a/src/core/ngx_string.c
> > +++ b/src/core/ngx_string.c
> > @@ -703,14 +703,14 @@ ngx_strlcasestrn(u_char *s1, u_char *las
> > {
> > ngx_uint_t c1, c2;
> >
> > - if (s1 <= last) {
> > - return NULL;
> > - }
> > -
> > c2 = (ngx_uint_t) *s2++;
> > c2 = (c2 >= 'A' && c2 <= 'Z') ? (c2 | 0x20) : c2;
> > last -= n;
> >
> > + if (s1 >= last) {
> > + return NULL;
> > + }
> > +
> > do {
> > do {
> > if (s1 == last) {
> >
> >
> > Shame on me again.
> >
> > Maxim Dounin
> >
> > p.s. 0.7.49 doesn't handle $args_* at all.
>
> Yes. Actually it's enough:
>
> do {
> do {
> if (s1 >= last) {

Yes, of course. For some reason I was under impression that "=="
check should be a bit faster, but looks like it's not true at
least with modern compilers / processors. At least gcc compiles
"==" and ">=" to nearly identical CMP+JCC.

Maxim Dounin
Subject Author Posted

nginx-0.7.49

Igor Sysoev April 06, 2009 06:45AM

Re: nginx-0.7.49

Maxim Dounin April 06, 2009 07:30AM

Re: nginx-0.7.49

Maxim Dounin April 06, 2009 07:42AM

Re: nginx-0.7.49

Igor Sysoev April 06, 2009 07:44AM

Re: nginx-0.7.49

Maxim Dounin April 06, 2009 11:23AM



Sorry, only registered users may post in this forum.

Click here to login

Online Users

Guests: 106
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready