Welcome! Log In Create A New Profile

Advanced

Re: Segfault in NGINX - testcase

Maxim Dounin
March 19, 2010 09:10PM
Hello!

On Fri, Mar 19, 2010 at 04:19:43PM -0400, double wrote:

> Hello,
>
> NGINX will segfault, if you delete the root node in an rbtree with
> two elements. Testcase:
> http://doppelbauer.name/nginx-testcase.c
>
> A patch is attached below.

>From what I see it's your function ngx_rbtree_next() which
segfaults, not nginx. It tries to identify root node via checking
it's parent against NULL - which is not correct way to do it, you
should instead compare node pointer against tree root pointer.

If you do still think that nginx is affected - please provide
another test case. The one which uses nginx, not code borrowed
from it, is preffered - see http://mdounin.ru/hg/nginx-tests/ for
some framework and test samples.

Maxim Dounin

_______________________________________________
nginx mailing list
nginx@nginx.org
http://nginx.org/mailman/listinfo/nginx
Subject Author Posted

Segfault in NGINX - testcase

double March 19, 2010 04:19PM

Re: Segfault in NGINX - testcase

Maxim Dounin March 19, 2010 09:10PM

Re: Segfault in NGINX - testcase

double March 20, 2010 04:43AM

Re: Segfault in NGINX - testcase

Maxim Dounin March 20, 2010 04:34PM

Re: Segfault in NGINX - testcase

double March 20, 2010 04:48PM

Re: Segfault in NGINX - testcase

double March 25, 2010 02:08PM

Re: Segfault in NGINX - testcase

double March 25, 2010 03:30PM



Sorry, only registered users may post in this forum.

Click here to login

Online Users

Guests: 272
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready