Welcome! Log In Create A New Profile

Advanced

Re: [PROPOSAL PATCH] use a return code for ngx_http_terminate_request()

Maxim Dounin
June 27, 2014 03:40PM
Hello!

On Fri, Jun 27, 2014 at 09:07:27AM -0400, crespin wrote:

> Hello,
>
> Reading ngx_http_request.c source code, I notice some call to
> ngx_http_terminate_request() is called sometimes with 0 instead of a return
> code.
>
> 0 is a correct valid for a return code ... it's NGX_OK.
>
> Is the patch valid ?

The ngx_http_terminate_request() function uses "rc" only when it's
positive, and "0" doesn't really mean anything except "we don't
have error code".

--
Maxim Dounin
http://nginx.org/

_______________________________________________
nginx mailing list
nginx@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx
Subject Author Posted

[PROPOSAL PATCH] use a return code for ngx_http_terminate_request()

crespin June 27, 2014 09:07AM

Re: [PROPOSAL PATCH] use a return code for ngx_http_terminate_request()

Maxim Dounin June 27, 2014 03:40PM



Sorry, only registered users may post in this forum.

Click here to login

Online Users

Guests: 227
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready