Welcome! Log In Create A New Profile

Advanced

Re: autoindex hiding dot folders

May 08, 2014 09:56AM
Thanks for your feedback itpp2012!

>> Very useful patch but the naming is not correct, . and .. or not your typical hidden type, autoindex_show_dot_folders would make more sense.


You are right, the wording "hidden" is not really good here because "files" starting with a 'dot' would only be hidden primarily on unix/linux type system and not e.g: in windows. However since in linux terminology everything is treated like files (e.g: device files, pipes, directories) I think 'autoindex_show_dot_files' would make more sense than 'show_dot_folders'.


>> And "if (ngx_de_name(&dir)[0] == '.') {" will exclude files which start with a dot,
>> if (ngx_de_name(&dir) == '.') or (ngx_de_name(&dir) == '..') {, would be better IMHO.


I wanted to target all "files" this way, including the file referencing to the current directory ("./")as well as the parent directory ("../"). The autoindex module would (without this patch) anyway add a html reference to the parent directory.

Hence I took your advice and changed the text with a little twist by changing the option text from "autoindex_show_hidden_files" to "autoindex_show_dot_files" ;-) Hope this makes sense for you and everyone else

I will post an update to this patch in the bug tracker.

Thanks,
Shin
Subject Author Posted

autoindex hiding dot folders

eiji-gravion October 15, 2011 05:41PM

Re: autoindex hiding dot folders

Maxim Dounin October 15, 2011 05:46PM

Re: autoindex hiding dot folders

shinsterneck May 07, 2014 08:49PM

Re: autoindex hiding dot folders

itpp2012 May 08, 2014 03:23AM

Re: autoindex hiding dot folders

shinsterneck May 08, 2014 09:56AM



Sorry, only registered users may post in this forum.

Click here to login

Online Users

Guests: 48
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready