Welcome! Log In Create A New Profile

Advanced

Re: So is "rewrite_by_lua" also evil?

Nginx User
October 15, 2011 07:08AM
On 15 October 2011 13:25, Eugaia <ngx.eugaia@gmail.com> wrote:
> On 15/10/2011 12:57, Nginx User wrote:
>>
>> Any thoughts on Marcus' points earlier on clearing the ctx in the core?
>> Seems to suggest that may cause problems elsewhere and that it is
>> better to be handled at the module level.
>> Seems logical as whether it was originally an oversight or not,
>> changing it now would break other stuff.
>
> I had a closer look at the code, and in fact clearing the contexts
> automatically won't break my code in particular because I don't use
> ngx_http_named_location() to find named locations (I find the location at
> conf-read time, not run time, since it's more efficient).  There may be
> other developers that use the function at runtime, but my guess is that it's
> probably not commonly used by module developers who would not prefer the
> contexts to be reset.
>
> I would therefore agree with agentzh and Maxim about it probably being the
> best way to go, and should any developers create modules that currently call
> ngx_http_named_location() but don't want to clear the contexts, then they
> can just re-write the function to not do so.

Great.

I'll therefore look into applying agentzh's patch then. I had held off
because your previous comment.

_______________________________________________
nginx mailing list
nginx@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx
Subject Author Posted

So is "rewrite_by_lua" also evil?

Nginx User October 11, 2011 12:04PM

Re: So is "rewrite_by_lua" also evil?

agentzh October 11, 2011 08:18PM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 12, 2011 12:14AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 12, 2011 12:22AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 12, 2011 12:50AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 12, 2011 02:38PM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 12, 2011 05:36PM

Re: So is "rewrite_by_lua" also evil?

agentzh October 12, 2011 10:08PM

Re: So is "rewrite_by_lua" also evil?

agentzh October 12, 2011 11:58PM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 13, 2011 12:36AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 13, 2011 12:34AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 13, 2011 12:56AM

Re: So is "rewrite_by_lua" also evil?

Eugaia October 14, 2011 07:02AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 14, 2011 07:42AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 12, 2011 09:36PM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 13, 2011 12:32AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 13, 2011 12:54AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 13, 2011 02:02AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 13, 2011 12:12PM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 13, 2011 08:18PM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 14, 2011 09:28AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 14, 2011 03:26PM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 14, 2011 03:26PM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 14, 2011 04:42PM

Re: So is "rewrite_by_lua" also evil?

agentzh October 15, 2011 02:38AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 15, 2011 04:48AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 15, 2011 05:42AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 15, 2011 05:58AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 15, 2011 06:08AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 15, 2011 07:38AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 15, 2011 09:24AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 15, 2011 10:22AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 16, 2011 12:30AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 16, 2011 07:12AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 16, 2011 11:44AM

Re: So is "rewrite_by_lua" also evil?

Eugaia October 15, 2011 06:26AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 15, 2011 07:08AM

Re: So is "rewrite_by_lua" also evil?

Eugaia October 15, 2011 06:18AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 15, 2011 06:34AM

Re: So is "rewrite_by_lua" also evil?

Eugaia October 15, 2011 06:46AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 15, 2011 07:10AM

Re: So is "rewrite_by_lua" also evil?

Eugaia October 15, 2011 07:40AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 16, 2011 12:18AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 14, 2011 09:28PM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 15, 2011 04:34AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 13, 2011 08:38PM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 14, 2011 04:32AM

Re: So is "rewrite_by_lua" also evil?

MyName October 12, 2011 06:23AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 12, 2011 06:32AM



Sorry, only registered users may post in this forum.

Click here to login

Online Users

Guests: 61
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready