Welcome! Log In Create A New Profile

Advanced

Re: So is "rewrite_by_lua" also evil?

agentzh
October 15, 2011 06:08AM
On Sat, Oct 15, 2011 at 5:57 PM, Nginx User <nginx@nginxuser.net> wrote:
> All in all, I have come to realise that ngx_lua is slightly evil in
> that unexpected things can happen. As with "if" however, evil
> understood is evil avoided :-)
>

The ngx_lua module won't play seamlessly with ngx_rewrite because
ngx_rewrite does use internal hacks and tricks to make things work. So
I'd recommend use Lua to do as much as possible and avoid using
ngx_rewrite's directives but simple "set".

> Any thoughts on Marcus' points earlier on clearing the ctx in the core?

Well, there're indeed cases that we do want to retain module contexts
during a jump but I've already managed to "abuse" the post_subrequest
mechanism to save the pointer to my module's context and later restore
it in my output header filter, for example. (See how I do this in my
ngx_lua module for ngx.location.capture.)

But on the other hand, if I do want to clear my module's context
before a internal redirection, then there's no easy way to do that
myself.

> Seems to suggest that may cause problems elsewhere and that it is
> better to be handled at the module level.

No, this is impossible to handle that fully on the module level. For
example, if you do use ngx_upload module's upload_pass instead of
ngx_lua or ngx_echo to do the jump, then it'll still break
rewrite_by_lua and access_by_lua (at least).

> Seems logical as whether it was originally an oversight or not,
> changing it now would break other stuff.
>

I doubt it :) Unless one only jump to named locations and never to
normal locations. The behaviors here are already inconsistent and very
hard to work around.

Regards,
-agentzh

_______________________________________________
nginx mailing list
nginx@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx
Subject Author Posted

So is "rewrite_by_lua" also evil?

Nginx User October 11, 2011 12:04PM

Re: So is "rewrite_by_lua" also evil?

agentzh October 11, 2011 08:18PM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 12, 2011 12:14AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 12, 2011 12:22AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 12, 2011 12:50AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 12, 2011 02:38PM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 12, 2011 05:36PM

Re: So is "rewrite_by_lua" also evil?

agentzh October 12, 2011 10:08PM

Re: So is "rewrite_by_lua" also evil?

agentzh October 12, 2011 11:58PM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 13, 2011 12:36AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 13, 2011 12:34AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 13, 2011 12:56AM

Re: So is "rewrite_by_lua" also evil?

Eugaia October 14, 2011 07:02AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 14, 2011 07:42AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 12, 2011 09:36PM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 13, 2011 12:32AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 13, 2011 12:54AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 13, 2011 02:02AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 13, 2011 12:12PM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 13, 2011 08:18PM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 14, 2011 09:28AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 14, 2011 03:26PM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 14, 2011 03:26PM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 14, 2011 04:42PM

Re: So is "rewrite_by_lua" also evil?

agentzh October 15, 2011 02:38AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 15, 2011 04:48AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 15, 2011 05:42AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 15, 2011 05:58AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 15, 2011 06:08AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 15, 2011 07:38AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 15, 2011 09:24AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 15, 2011 10:22AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 16, 2011 12:30AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 16, 2011 07:12AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 16, 2011 11:44AM

Re: So is "rewrite_by_lua" also evil?

Eugaia October 15, 2011 06:26AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 15, 2011 07:08AM

Re: So is "rewrite_by_lua" also evil?

Eugaia October 15, 2011 06:18AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 15, 2011 06:34AM

Re: So is "rewrite_by_lua" also evil?

Eugaia October 15, 2011 06:46AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 15, 2011 07:10AM

Re: So is "rewrite_by_lua" also evil?

Eugaia October 15, 2011 07:40AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 16, 2011 12:18AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 14, 2011 09:28PM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 15, 2011 04:34AM

Re: So is "rewrite_by_lua" also evil?

agentzh October 13, 2011 08:38PM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 14, 2011 04:32AM

Re: So is "rewrite_by_lua" also evil?

MyName October 12, 2011 06:23AM

Re: So is "rewrite_by_lua" also evil?

Nginx User October 12, 2011 06:32AM



Sorry, only registered users may post in this forum.

Click here to login

Online Users

Guests: 257
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready