Welcome! Log In Create A New Profile

Advanced

Re: Nginx 1.0.5 in windows heap corruption

Maxim Dounin
August 21, 2011 12:32PM
Hello!

On Sun, Aug 21, 2011 at 12:07:06PM -0400, hydra wrote:

> Hi,
> When I use Nginx 1.0.5 in WINDOWS, It message a box with information
> that is heap corruption.
> I use Visual Studio to debug it and find that in
> src/os/win32/ngx_file.c line 224 ngx_win32_rename_file() .
> When I do like this:
>
> ngx_err_t
> ngx_win32_rename_file(ngx_str_t *from, ngx_str_t *to, ngx_log_t *log)
> {
> u_char *name;
> ngx_err_t err;
> ngx_uint_t collision;
> ngx_atomic_uint_t num;
> size_t size;
>
> size = to->len + 1 + 10 + 1 + sizeof("DELETE") + 1;

Thank you for report. It looks like "10" here should be
instead NGX_ATOMIC_T_LEN here.

Could you please test the following patch?

diff --git a/src/os/win32/ngx_files.c b/src/os/win32/ngx_files.c
--- a/src/os/win32/ngx_files.c
+++ b/src/os/win32/ngx_files.c
@@ -228,7 +228,8 @@ ngx_win32_rename_file(ngx_str_t *from, n
ngx_uint_t collision;
ngx_atomic_uint_t num;

- name = ngx_alloc(to->len + 1 + 10 + 1 + sizeof("DELETE"), log);
+ name = ngx_alloc(to->len + 1 + NGX_ATOMIC_T_LEN + 1 + sizeof("DELETE"),
+ log);
if (name == NULL) {
return NGX_ENOMEM;
}


Maxim Dounin

_______________________________________________
nginx mailing list
nginx@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx
Subject Author Posted

Nginx 1.0.5 in windows heap corruption

hydra August 21, 2011 12:07PM

Re: Nginx 1.0.5 in windows heap corruption

Maxim Dounin August 21, 2011 12:32PM

Re: Nginx 1.0.5 in windows heap corruption

hydra August 21, 2011 09:56PM

Re: Nginx 1.0.5 in windows heap corruption

Igor Sysoev August 21, 2011 11:18PM

Re: Nginx 1.0.5 in windows heap corruption

Maxim Dounin August 22, 2011 06:14AM

Re: Nginx 1.0.5 in windows heap corruption

hydra August 23, 2011 12:27AM

Re: Nginx 1.0.5 in windows heap corruption

Igor Sysoev August 21, 2011 12:56PM

Re: Nginx 1.0.5 in windows heap corruption

Maxim Dounin August 21, 2011 03:10PM

Re: Nginx 1.0.5 in windows heap corruption

Igor Sysoev August 21, 2011 11:16PM

Re: Nginx 1.0.5 in windows heap corruption

hydra August 21, 2011 09:58PM



Sorry, only registered users may post in this forum.

Click here to login

Online Users

Guests: 63
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready