Welcome! Log In Create A New Profile

Advanced

Re: Clang scan-build output

Maxim Dounin
November 04, 2009 09:18PM
Hello!

On Wed, Nov 04, 2009 at 04:51:50PM -0800, Cliff Wells wrote:

> That's a pretty cool tool. Surprising though that some really
> simplistic stuff generated false positives, e.g.:
>
> "Value stored to 'qclass' is never read"
>
> qtype = (an->type_hi << 8) + an->type_lo;
> qclass = (an->class_hi << 8) + an->class_lo;
> len = (an->len_hi << 8) + an->len_lo;
> ngx_log_debug3(NGX_LOG_DEBUG_CORE, r->log, 0,
> "resolver qt:%ui cl:%ui len:%uz", qtype, qclass, len);

Brian aparently analyzed build without debug, and ngx_log_debug3()
resolves to nop there. So it's not really false positive, but
wrapping such cases into "#if (NGX_DEBUG)" just to make analyzer
happy looks like overkill.

Maxim Dounin

>
> Cliff
>
> On Wed, 2009-11-04 at 14:59 -0800, Akins, Brian wrote:
> > Output from the clang static analyzer ( http://clang-analyzer.llvm.org/ )
> > for nginx-0.7.63
> >
> > http://www.akins.org/scan-build-2009-11-04-1/index.html
> >
> >
> --
> http://www.google.com/search?q=vonage+sucks
>
>
Subject Author Posted

Clang scan-build output

Akins, Brian November 04, 2009 06:04PM

Re: Clang scan-build output

Cliff Wells November 04, 2009 07:58PM

Re: Clang scan-build output

张立冰 November 04, 2009 08:32PM

Re: Clang scan-build output

Maxim Dounin November 04, 2009 09:18PM

Re: Clang scan-build output

Adrian Perez de Castro November 05, 2009 05:48AM

Re: Clang scan-build output

Maxim Dounin November 04, 2009 09:14PM

Re: Clang scan-build output

Akins, Brian November 05, 2009 01:46PM



Sorry, only registered users may post in this forum.

Click here to login

Online Users

Guests: 58
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready