Welcome! Log In Create A New Profile

Advanced

potential null dereference

alexc@sbrella.com
February 15, 2017 11:02PM
Hi,

In file /src/http/ngx_http_upstream.c, function
ngx_http_upstream_finalize_request


// if u->pipe == NULL, ngx_http_file_cache_free(r->cache, u->pipe->temp_file); will dereference a null pointer, it's that right ?

// Regards
// Alex

if (u->store && u->pipe && u->pipe->temp_file
&& u->pipe->temp_file->file.fd != NGX_INVALID_FILE)
{
if (ngx_delete_file(u->pipe->temp_file->file.name.data)
== NGX_FILE_ERROR)
{
ngx_log_error(NGX_LOG_CRIT, r->connection->log, ngx_errno,
ngx_delete_file_n " \"%s\" failed",
u->pipe->temp_file->file.name.data);
}
}

#if (NGX_HTTP_CACHE)

if (r->cache) {

......

ngx_http_file_cache_free(r->cache, u->pipe->temp_file);
}




alexc@sbrella.com
_______________________________________________
nginx mailing list
nginx@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx
Subject Author Posted

potential null dereference

alexc@sbrella.com February 15, 2017 11:02PM

Re: potential null dereference

B.R. via nginx February 16, 2017 03:46AM

Re: potential null dereference

Maxim Dounin February 16, 2017 08:22AM



Sorry, only registered users may post in this forum.

Click here to login

Online Users

Guests: 257
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready