Welcome! Log In Create A New Profile

Advanced

Re: Random order of configuration file reading

All files from this thread

File Name File Size   Posted by Date  
include-sorted.patch 395 bytes open | download Joshua Zhu 11/28/2012 Read message
Maxim Dounin
November 29, 2012 06:26PM
Hello!

On Wed, Nov 28, 2012 at 06:15:50PM +0400, Maxim Dounin wrote:

> Hello!
>
> On Wed, Nov 28, 2012 at 01:27:04PM +0100, Antonio P.P. Almeida wrote:
>
> > > Hello!
> >
> > > I've already proposed removing GLOB_NOSORT to Igor a while ago.
> > > His position on this is to keep this in sync with Windows version
> > > where there is no sort guaranties.
> > >
> > > [...]
> >
> > Can't we just pass that as a config option so that the configure script
> > detects the build environment and if were on *NIX the sorting is enabled?
>
> The codepath in question is unix-only, the question is about user
> experience which will be different on unix and win32 with
> GLOB_NOSORT removed on unix.
>
> Right now one can't rely on wildcard include ordering, and this is
> consistent for all platforms supported. And "listen ... default"
> should be used to mark default server if one uses wildcard include
> to include multiple server blocks listening on the same some
> ip:port. With the GLOB_NOSORT removed the behaviour will be
> different on unix (included files will be sorted) and win32
> (included files are not guaranteed to be sorted), which is
> considered bad.
>
> (I personally think that GLOB_NOSORT should be removed anyway.
> I'll talk to Igor again about this.)

I've discussed this with Igor, and this time he finnally approved
removing GLOB_NOSORT. Committed,

http://trac.nginx.org/nginx/changeset/4944/nginx

Thanks to all for prodding this.

--
Maxim Dounin
http://nginx.com/support.html

_______________________________________________
nginx mailing list
nginx@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx
Subject Author Posted

Random order of configuration file reading

philipp November 27, 2012 09:07AM

Re: Random order of configuration file reading Attachments

Joshua Zhu November 28, 2012 06:50AM

Re: Random order of configuration file reading

Antonio P.P. Almeida November 28, 2012 07:28AM

Re: Random order of configuration file reading

Antonio P.P. Almeida November 28, 2012 07:30AM

Re: Random order of configuration file reading

Maxim Dounin November 28, 2012 09:16AM

Re: Random order of configuration file reading

Maxim Dounin November 29, 2012 06:26PM

Re: Random order of configuration file reading

Joshua Zhu November 30, 2012 12:24AM

Re: Random order of configuration file reading

Gena Makhomed November 28, 2012 07:56AM



Sorry, only registered users may post in this forum.

Click here to login

Online Users

Guests: 289
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready